Skip to content

Add support for increased mod magnitude mods#9955

Merged
LocalIdentity merged 8 commits into
PathOfBuildingCommunity:devfrom
vaisest:advanced-mod-scaling
Jul 23, 2026
Merged

Add support for increased mod magnitude mods#9955
LocalIdentity merged 8 commits into
PathOfBuildingCommunity:devfrom
vaisest:advanced-mod-scaling

Conversation

@vaisest

@vaisest vaisest commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Fixes no issues but this will be a problem when advanced copy is the default.

Description of the problem being solved:

This solves:

  • Mod magnitude mods not being supported. This became relevant when advanced mod support was added.
  • Other mod effect mods such as jewels and experimented rings
  • The life and mana costs catalyst not applying because the pattern didn't match spaces

Steps taken to verify a working solution:

  • former tests pass
  • items render correctly when manually tested
  • automated tests were added
  • Also seemed to work in pob2

Make sure to paste twice in case the item "crafts" on paste which won't necessarily add the correct mods to it. This is a separate issue.

Link to a build that showcases this PR:

Item Class: Rings
Rarity: Rare
Torment Hold
Helical Ring
--------
Quality (Resistance Modifiers): +20% (augmented)
--------
Requirements:
Level: 67
--------
Item Level: 84
--------
{ Implicit Modifier }
-2 Prefix Modifiers allowed
+1 Suffix Modifier allowed
Implicit Modifiers Cannot Be Changed — Unscalable Value
50% increased Suffix Modifier magnitudes — Unscalable Value
--------
{ Prefix Modifier "Robust" (Tier: 3) — Life }
+73(70-84) to maximum Life
{ Fractured Suffix Modifier "of the Rainbow" (Tier: 1) — Elemental, Resistance  — 70% Increased }
+15(15-16)% to all Elemental Resistances
{ Suffix Modifier "of Bameth" (Tier: 1) — Chaos, Resistance  — 70% Increased }
+32(31-35)% to Chaos Resistance
{ Suffix Modifier "of Tzteosh" (Tier: 1) — Elemental, Fire, Resistance  — 70% Increased }
+48(46-48)% to Fire Resistance
{ Master Crafted Suffix Modifier "of Craft" — Elemental, Fire, Chaos, Resistance  — 70% Increased }
+15(13-15)% to Fire and Chaos Resistances
--------
Split
--------
Fractured Item
Item Class: Sceptres
Rarity: Unique
Nebulis
Synthesised Void Sceptre
--------
Sceptre
Quality: +20% (augmented)
Physical Damage: 60-93 (augmented)
Critical Strike Chance: 7.30%
Attacks per Second: 1.25
Weapon Range: 1.1 metres
--------
Requirements:
Level: 70
Str: 155
Int: 122 (unmet)
--------
Sockets: R-R-R 
--------
Item Level: 87
--------
Quality does not increase Physical Damage (enchant)
Grants 1% increased Area of Effect per 4% Quality (enchant)
--------
{ Implicit Modifier — Damage, Elemental, Fire  — 114% Increased }
26(24-26)% increased Fire Damage
{ Implicit Modifier — Damage, Physical, Attack  — 114% Increased }
Adds 5(5-6) to 8(7-8) Physical Damage
{ Implicit Modifier — Elemental, Fire, Ailment  — 114% Increased }
8(8-10)% increased Ignite Duration on Enemies
--------
{ Unique Modifier }
114(60-120)% increased Implicit Modifier magnitudes — Unscalable Value
(Implicit Modifiers are those that come from an item's type, rather than its random properties)
{ Unique Modifier — Caster, Speed }
18(15-20)% increased Cast Speed
{ Unique Modifier — Damage }
10(5-10)% increased Elemental Damage per 1% Fire, Cold, or Lightning Resistance above 75%
--------
The vastness of the cosmos holds energies beyond comprehension,
should one have the fortitude to grasp them.
--------
Synthesised Item
Item Class: Amulets
Rarity: Rare
Carrion Heart
Simplex Amulet
--------
Quality (Suffix Modifiers): +20% (augmented)
--------
Requirements:
Level: 65
--------
Item Level: 86
--------
Allocates Golem's Blood (enchant)
--------
{ Implicit Modifier }
-2 Prefix Modifiers allowed
-1 Suffix Modifier allowed
Implicit Modifiers Cannot Be Changed — Unscalable Value
100% increased Explicit Modifier magnitudes — Unscalable Value
--------
{ Prefix Modifier "Athlete's" (Tier: 1) — Life  — 100% Increased }
-211(115-129) to maximum Life
{ Suffix Modifier "of the Essence" — Damage, Critical  — 120% Increased }
-65(35-41)% to Global Critical Strike Multiplier
{ Suffix Modifier "of Legerdemain" (Tier: 1) — Caster, Speed  — 120% Increased }
32(-17--20)% reduced Cast Speed
--------
Mirrored
--------
Split
--------
Note: ~b/o 9999 mirror
Item Class: Amulets
Rarity: Rare
Morbid Beads
Simplex Amulet
--------
Quality (Life and Mana Modifiers): +20% (augmented)
--------
Requirements:
Level: 65
--------
Item Level: 85
--------
Allocates Disciple of the Unyielding (enchant)
--------
{ Implicit Modifier }
-2 Prefix Modifiers allowed
-1 Suffix Modifier allowed
Implicit Modifiers Cannot Be Changed — Unscalable Value
100% increased Explicit Modifier magnitudes — Unscalable Value
--------
{ Prefix Modifier "Athlete's" (Tier: 1) — Life  — 120% Increased }
+262(115-129) to maximum Life
{ Suffix Modifier "of the Essence" — Damage, Critical  — 100% Increased }
+81(35-41)% to Global Critical Strike Multiplier
{ Master Crafted Suffix Modifier "of Craft"  — 100% Increased }
+2(1) to Minimum Endurance Charges
--------
Mirrored
--------
Split
--------
Note: ~b/o 11 mirror

Before screenshot:

After screenshot:

@vaisest
vaisest force-pushed the advanced-mod-scaling branch from 95ea4b8 to 7e6cb6e Compare July 22, 2026 18:10
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Jul 23, 2026
@LocalIdentity
LocalIdentity merged commit 616e3ac into PathOfBuildingCommunity:dev Jul 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants